LunarVim / Launch.nvim

🚀 Launch.nvim is modular starter for Neovim.
GNU General Public License v3.0
2k stars 474 forks source link

Neovim 0.9 release now with lazy.nvim many new things #112

Closed Rishabh672003 closed 1 year ago

jellydn commented 1 year ago

FYI - I've migrated from Packer to Lazy for my nvim config. You could take a look for reference https://github.com/jellydn/nvim-ide

Rishabh672003 commented 1 year ago

oh good to see someone has already done that with basic-ide

rrrix commented 1 year ago

@Rishabh672003 you're changing a lot more than just the plugin manager in this PR.

You will have a far greater chance of getting this merged if you update your PR description with detail (justification) about what else you're changing (and why it should be in this PR).

IMO if you want to perform other structural changes (file renames, variable/function refactoring) that should go into a seperate PR so they can be reviewed, critiqued, merged separately.

Writing good PR's takes practice :)

I wanted to give this a try, but after looking at the changes, it looks like there's too many other pieces being touched than just switching from packer.nvim to lazy.nvim.

Rishabh672003 commented 1 year ago

You will have a far greater chance of getting this merged if you update your PR description with detail (justification) about what else you're changing (and why it should be in this PR).

thanks for your worries and i do agree that this is not a perfect pr (and i am learning how to make one also these days i dont have a lot of time to work on this) But you dont need to worry about it because i am the one maintaining the repo and when this is completed i am the one that will merge it Still thanks for your feedback