search

LunarVim / Neovim-from-scratch

📚 A Neovim config designed from scratch to be understandable
https://www.chrisatmachine.com/
GNU General Public License v3.0
5.31k stars 1.17k forks source link

Fix of a breaking change in the last version of vim-cmp #223

Closed korniychuk closed 1 year ago

korniychuk commented 1 year ago

I'm not sure whether it is a bug or a breaking change, but this config stopped working without specifying the max_width & max_height. How to reproduce the error:

  1. open a .lua file
  2. print fn somewhere
  3. pres <tab> twice

The line in the vim-cmp that breaks documentation popup: https://github.com/hrsh7th/nvim-cmp/blob/main/lua/cmp/view/docs_view.lua#L39

Screenshot 2022-09-09 14 07 12@2x

korniychuk commented 1 year ago

Wow, I found that if I change documentation to window the error disappears. So, it would be better to merge next PR instead of my: https://github.com/LunarVim/Neovim-from-scratch/pull/204/files

gnmearacaun commented 1 year ago

Fixed in #231. Thanks for your efforts.