search

LunarVim / Neovim-from-scratch

📚 A Neovim config designed from scratch to be understandable
https://www.chrisatmachine.com/
GNU General Public License v3.0
5.31k stars 1.18k forks source link

Address deprecation warnings #298

Closed trekie86 closed 1 year ago

trekie86 commented 1 year ago

This change addresses deprecation warnings and updates cmp_nvim_lsp per https://github.com/hrsh7th/cmp-nvim-lsp/issues/38. Additional migration from sumneko_lua to lua_ls and the corresponding settings file.

fixes #294

trekie86 commented 1 year ago

Great thanks. I thought the spacing was accurate but I'll double check my nvim config to ensure it's replacing tabs with spaces to keep things consistent.

trekie86 commented 1 year ago

This should be able to resolve #294 unless we should go through to address each impacted branch as well.

gnmearacaun commented 1 year ago

Great thanks. I thought the spacing was accurate but I'll double check my nvim config to ensure it's replacing tabs with spaces to keep things consistent.

For sure, it's configured in options to expand tabs to (2) spaces. Github has a default set to 8 spaces, which is why it appears janky. The repo uses spaces (vs tabs) by default. The default can be changed in the Github user Settings > Appearance to change the default to two spaces, if desired. A few of the files are using tabs due to various authors including parts copied from other repos. There's a handy command :retab to replace tabs with spaces in a file. That's something we ought to do (including your fix above) in master in the fullness of time.

gnmearacaun commented 1 year ago

This should be able to resolve #294 unless we should go through to address each impacted branch as well.

Thanks, I've closed #294 now.

There are other problems with all of the later branches. Stuff that has been fixed already in master but just needs to be applied to those branches.