search

LunatiqueCoder / luna

Luna - a React Native + Next.js template. Built with TypeScript :heart:
https://luna-gamma.vercel.app/
MIT License
264 stars 17 forks source link

build(deps): update react-native/react-native-web w/tiny fixes to verify / ease developer usage #10

Closed mikehardy closed 2 years ago

mikehardy commented 2 years ago

Here's a batch of commits built on #9 with the general goal of carefully updating react-native, but with all the little things I would want along the way to quickly run things and test them to make sure they are good (especially since react-native-vector-icons went across a major version I needed to see that it was working on all platforms before I was comfortable with it)

The only thing that isn't possible now - that I know of - is moving across to the newest eslint version since there are some compatibility things that need to ripple out to all of the various configs etc, so those packages will still show up on yarn outdated until the ecosystem is ready

As this is built on #9, I can either rebase this one after that merges to clean out the commits from that one, or this can be rebase-merged in it's entirety while just closing #9

Same as #9 this one is best examined commit by commit - each one is intended to be very focused and easy to look at, with a specific comment related to the change on the commit

After this one I'm going to start building an app using the template, so it'll probably be a lot quieter from me going forward, since now the template is provably working on current stable versions, on all 3 platforms

Cheers :-)

LunatiqueCoder commented 2 years ago

Sorry, I wasn't home today, but I will take a better look tomorrow.

I reallly don't know how to thank you, Mike. I really appreciate everything you did in a few hours. I'm very happy that I met you, I will really have a lot to learn from a guy like you. Please feel free to add credits however you wish in the README.

Thank you a thousand times, once again!

mikehardy commented 2 years ago

No problem :-), and especially about not being around - it's all open source, no time pressure right? I just happened to need this template like right now, actually, last week :-), so I was all over it immediately. Might still be just a couple little tweaks, I'm still going through the process of react-native init with it in the app I need to build, but it's close. And thank you! Because I really needed a typescript+react-native-web template

mikehardy commented 2 years ago

Got it! If there's anything to learn it is: one tiny change at a time, with lots of automated testing. Super super methodical.

And it discovered that there is a transform problem in the battle between ES6 and commonJS in Jest, so I needed to ignore transforming certain modules pulled in by react-native-vector-icons after adding the vector icon to the test.

But I needed the vector icon to discover the iOS plist was missing fonts, it's all together ;-)

Now we have jest passing in CI with everything in there. I'm ready for app init now with this