search

LunatiqueCoder / luna

Luna - a React Native + Next.js template. Built with TypeScript :heart:
https://luna-gamma.vercel.app/
MIT License
264 stars 17 forks source link

Remove typeRoots and update tsconfig.json template #25

Closed LunatiqueCoder closed 2 years ago

LunatiqueCoder commented 2 years ago

This PR removes typeRoots from tsconfig.json because it was misused and is not working properly anyway. Also implements a template inspired from react-native-template-typescript

Fixes #22

LunatiqueCoder commented 2 years ago

I read through the wiki the other day and saw typeroots mentioned, does this need a corresponding change here? https://github.com/plaut-ro/luna/wiki#typescript

Absolutely, I believe I will update everything and release v1.1.0 by tonight.

change looks good though - I'm specifically clicking the comment button - not approve - as an assertion that my approval or not should never hold you back, I am just commenting when I think it's useful :-)

Thank you. The reason for not merging directly is because I appreciate you having a look (if you have the time of course). You always point out useful things, but I believe that's what reviews are for.