LunatiqueCoder / luna

Luna - a React Native + Next.js template. Built with TypeScript :heart:
https://luna-gamma.vercel.app/
MIT License
264 stars 17 forks source link

fix(android): android 12 compatibility #30

Closed mikehardy closed 2 years ago

mikehardy commented 2 years ago

should be noted in release docs that JDK11 is required to build reliably

These changes just landed on react-native main tree as well, and I'm seeing lots of related traffic in repos indicating developers are working through this process themselves right now in existing projects

Should update the template so it's in there out of the box

mikehardy commented 2 years ago

just a review note: there were no problems with the various bumps while using react-native 0.66.x - or even lower I think, down to 0.65.x. The only hold up at all on landing these on react-native main was their infrastructure had to work through the JDK11 upgrade. Once that was settled, this specific change was trivial and "Just Worked"