search

LunatiqueCoder / luna

Luna - a React Native + Next.js template. Built with TypeScript :heart:
https://luna-gamma.vercel.app/
MIT License
264 stars 17 forks source link

@mikehardy/lint battles #33

Closed mikehardy closed 2 years ago

mikehardy commented 2 years ago

A bunch of little battles I just won with eslint + prettier ;-)

Each comment has what I learned and the reference

what a pain in the ... haha

yarn lint:all is now completely clean with these, including in a real project where there are switch statements and export const enums and such

mikehardy commented 2 years ago

Hmmm :thinking: - obviously the goal is clean lint runs and I have that locally. I'll re-examine the lint failure a bit later to make sure this goes green in CI

mikehardy commented 2 years ago

Ah, it's on a component that doesn't exist anymore after #32 - or shouldn't - it does seem like the develop branch may be in a strange state ?

/home/runner/work/luna/luna/template/src/app/components/LearnMoreLinks/LearnMoreLinks.tsx

Error:    1:1   error    Delete `⏎`                                                                                                                                                                                                           prettier/prettier
Error:   17:31  error    Replace `'button'` with `"button"`                                                                                                                                                                                   prettier/prettier
Warning:   17:31  warning  Unexpected usage of singlequote                                                                                                                                                                                      jsx-quotes
LunatiqueCoder commented 2 years ago

Yep, it also seems to me that I messed something up with the develop branch, I'm trying to figure it out,

mikehardy commented 2 years ago

My firebase auth template on top of this one now does theming and language switching (including the built-in email auth templates that firebase gives you!). Just need a translation for 'ro' and you've got an out-of-the-box web/mobile app that's in your language - you might find that useful

LunatiqueCoder commented 2 years ago

I'm doing the last changes for Luna and I'll try the firebase example ASAP.

Unfortunately, I'm still on a vacation and my family demands my attention 😂 Trying to hop on the laptop whenever I have some spare time.

mikehardy commented 2 years ago

Oh hang with the family every time. Laptop will always be there... Cheers man :-)