LunatiqueCoder / luna

Luna - a React Native + Next.js template. Built with TypeScript :heart:
https://luna-gamma.vercel.app/
MIT License
264 stars 17 forks source link

Integrate bootsplash, standarize generic icon / splash names #45

Open mikehardy opened 2 years ago

mikehardy commented 2 years ago

Is your feature request related to a problem? Please describe.

I think every app needs a bootsplash. Nothing that slows app load down (that's a negative user experience) but it does take a moment for the bundle to load on web and mobile.

As an "every app needs it" problem (like react-navigation) with a solution that is singular in the community (react-native-bootsplash) I think it qualifies for adding it in even a basic template like here

Further, every app needs it but they all have different actual assets, so the names used should be generic if possible, and easy to regenerate asset catalogs for web/mobile from a command line tool (react-native-bootsplash provides one)

Describe the solution you'd like

Integrate react-native-bootsplash, using generic asset names, with help in that repo to land the web PR https://github.com/zoontek/react-native-bootsplash/pull/278

Describe alternatives you've considered Integrating react-native-bootsplash manually in all my apps built on this :laughing: like I am doing now But using v2 so I don't have Android12 support yet, and without the web PR yet so I also have custom web loading indicators

LunatiqueCoder commented 2 years ago

I actually also had this on my mind too, but I was wondering if there is anyone that might prefer react-native-splash-screen?

mikehardy commented 2 years ago

My god no :laughing: no no no https://github.com/crazycodeboy/react-native-splash-screen/issues/289#issuecomment-502406454

image

image

choose your packages wisely :-)

bootsplash is react-native-web compatible as well.

LunatiqueCoder commented 2 years ago

😂 Ok, I got it. Then bootsplash it is!