search

LunatiqueCoder / luna

Luna - a React Native + Next.js template. Built with TypeScript :heart:
https://luna-gamma.vercel.app/
MIT License
264 stars 17 forks source link

build(deps): yarn package:update, pin react-scripts@^4 #48

Closed mikehardy closed 2 years ago

mikehardy commented 2 years ago

react-scripts@5 just came out and on a whim I tried it, it was not pretty :sweat_smile: - pinning react-scripts to v4 for now

The errors were all webpack - 4 total, 3 of them were duplicates in three different files: a babel interop helper file being required out of src with a relative path, not sure what that's about

And the fourth error was prettier having conflicted plugin loads from the community eslint config and our file

With this set of updates everything seems to run on all three platforms

LunatiqueCoder commented 2 years ago

Nice, I'll have a closer look probably today, but I have to admit - I'm very very crowded these days at work. :( I think only for Christmas I'll be able to revamp Luna a bit.

mikehardy commented 2 years ago

There is no pressure ever, I just lodge PRs when I'm "in the area" and if they sit, they sit :-). I'm still sitting on your web auth ones for instance :sweat_smile: - same reason, really busy in specific areas and those are not the areas at the moment. Cheers !