search

LunatiqueCoder / luna

Luna - a React Native + Next.js template. Built with TypeScript :heart:
https://luna-gamma.vercel.app/
MIT License
264 stars 17 forks source link

fix(lint): silence warnings during web production build #52

Closed mikehardy closed 2 years ago

mikehardy commented 2 years ago

craco / webpack was complaining about some of our language proposal choices not lining up correctly, this silences the warnings

mikehardy commented 2 years ago

Oops!

FAIL src/__tests__/App-test.tsx
  ● Test suite failed to run

    .plugins[1] must be a string, object, function

      at assertPluginTarget (node_modules/babel-jest/node_modules/@babel/core/lib/config/validation/option-assertions.js:264:[11](https://github.com/plaut-ro/luna/runs/5498093095?check_suite_focus=true#step:8:11))
          at Array.forEach (<anonymous>)
          at Array.forEach (<anonymous>)

investigating / will re-push once I've got root cause + fix, should be easy? Hope it's easy ;-)

mikehardy commented 2 years ago

CI saved me/us from a really stupid error there! Missing a comma in the react-native babel.config.js - webpack part was fine :facepalm: - now should work