LunatiqueCoder / react-native-media-console

A React Native video player. Built with TypeScript ❤️
MIT License
192 stars 29 forks source link

Custom icons and props for controls #37

Open LunatiqueCoder opened 1 year ago

LunatiqueCoder commented 1 year ago
poojan010 commented 1 year ago

can you add props like renderPlayIcon, renderPauseIcon, renderForwardIcon, renderReplayIcon so user can set icons according to there need they can even use vector icons there

TomPrice2023 commented 1 year ago

Hi, just wondering if there has been any progress on this enhancement or if it is something you would be open to have contributors look into. Thanks for all the work you've put into this package!

LunatiqueCoder commented 1 year ago

Hey @TomPrice2023 . Unfortunately there hasn't been made any progress, but in case the community requires it, it can gain a higher priority. Is it something you need?

TomPrice2023 commented 1 year ago

Hi @LunatiqueCoder, thank you for the update! I definitely think it would be very useful. The package is awesome and being able to align the end result to what the designers have mocked up would be perfect! I'd also be curious to see if positioning icons is something that this enhancement could make possible.

Thanks again!

LunatiqueCoder commented 1 year ago

@TomPrice2023 I think repositioning would be a littler bit harder. I am curious what's your use case more precisely? Maybe we can find an easy implementation.

TomPrice2023 commented 1 year ago

The positioning would revolve around the controls which sit in the corners: full screen, volume, back. I was thinking something along the lines of topLeft, topRight, bottomLeft & bottomRight mapping to each control could maybe add a nice bit of flexibility to how the player looks.

LunatiqueCoder commented 1 year ago

@TomPrice2023 This is actually a nice idea but we have to think very well about it. Probably won't be something to expect soon...