LunatiqueCoder / react-native-media-console

A React Native video player. Built with TypeScript ❤️
MIT License
194 stars 29 forks source link

Darken Overlay Background for Light Video Backgrounds #51

Closed esegebart closed 1 year ago

esegebart commented 1 year ago

Changed the opacity to be twice as dark so if there is a very light background the controls do not get lost against the video. The video is still able to be seen underneath the overlay.

LunatiqueCoder commented 1 year ago

Looks great! I'll test it tomorrow on my project and see how it looks. Thank you!

esegebart commented 1 year ago

Oh ! Nope I do not need those. I think I added them when I was trying to load the project thinking I needed them, but I don't! I will remove !

LunatiqueCoder commented 1 year ago

Don’t worry, just asking. Unfortunately, I didn’t have time to test changes, but I will definitely do it tomorrow. Have a nice weekend!

esegebart commented 1 year ago

@criszz77 If you have time, could you tell me if there is any way to debug / console.log when running or using the media console project? I am trying to understand where data is passed through to see how everything works. Otherwise you have a nice weekend also and I will touch base with you on Monday!

LunatiqueCoder commented 1 year ago

Sure. The normal way should work. Just do your changes, and then follow the instrunctions. The logs should appear where you normally check for logs.

esegebart commented 1 year ago

@criszz77 Awesome, thank you so much for your help. :)

LunatiqueCoder commented 1 year ago

Hey

Sorry for not giving too much attention as promised... but this week we'll definitely merge it