search

LunatiqueCoder / react-native-media-console

A React Native video player. Built with TypeScript ❤️
MIT License
184 stars 28 forks source link

feat(seekbar, volume): add the ability to control the direction of se… #71

Closed jspizziri closed 1 year ago

jspizziri commented 1 year ago

…ek and volume PanResponders

jspizziri commented 1 year ago

The purpose of this PR is to allow for the control of the PanReponders in the event a transformation has occurred on the video player view.

As a specific example, we support fullscreen mode via an animated style transformation on a view wrapping the video player. When the device is in a Landscape orientation the player is either under a 90deg or -90deg rotation. As it currently stands the PanResponders don't like this as they currently only support panning along the x axis, however, we now need to pan on the y. Moreover, you need the ability to control the inversion of the responder in these situations as well given the negative or positive direction of rotation.

Would love feedback, and thanks for the lib.

LunatiqueCoder commented 1 year ago

Ohh this looks actually very nice! I'll try to have a look this weekend. Thank you for the PR and feedback!

jspizziri commented 1 year ago

@LunatiqueCoder any thoughts on this? It's not super pressing for me as I've published my fork to npm, but I would love to not have to use a fork :).

LunatiqueCoder commented 1 year ago

Ahh sorry, I was so busy lately. I'll try again this week. 🙈 Sorry for the inconvenience.

The code looks good, I just have to test it. 👌

jspizziri commented 1 year ago

no apologies needed!

jspizziri commented 1 year ago

Just a friendly ping on this.

LunatiqueCoder commented 1 year ago

Thank you very much! I didn't test it very carefully, but it looks good.