search

LunchBadger / lunchbadger-ui

Apache License 2.0
3 stars 2 forks source link

Editable names of custom properties #1179

Open kolbinski opened 5 years ago

kolbinski commented 5 years ago

Instead of 2 separate fields: Property name and value, use 1 fields, with editable top small field name.

kolbinski commented 5 years ago

@altsang Ready for tests on staging. Custom properties have now editable name as labels:

Zrzut ekranu 2019-03-25 o 20 46 54

It applies also for other use cases, like in policies:

Zrzut ekranu 2019-03-25 o 20 57 38

altsang commented 5 years ago

looks good - the only weird thing though is that when clicking the + you're asked the data type first, I think we should let them put in the label and then ask what kind of data type afterwards and change the UX a bit - possible?

kolbinski commented 5 years ago

@altsang Possible, but... user clicks + in top right corner, new label input is present, user fills label, and then what? We should display another + icon near the label? And after user select type, this icon should disappear? Anyway, let's close this card and separate new requirements to new card.