LunchBadger / lunchbadger-ui

Apache License 2.0
3 stars 2 forks source link

Gateway entity new prototype #48

Closed kolbinski closed 7 years ago

kolbinski commented 7 years ago

Make a Gateway UI component according to new prototype provided by Stacy: https://github.com/stacy-hunt/lunchbadger-gateway

kolbinski commented 7 years ago

Commit reviews: 1) https://github.com/LunchBadger/lunchbadger-ui/commit/b4948cd0b97e0612e11e886ada3ef2b51e66be52 2) https://github.com/LunchBadger/lunchbadger-ui/commit/4041e231aebfcff1e951756ac5b2491513be05c9

jimhw commented 7 years ago
jimhw commented 7 years ago

Reviewed the codes and all the prior changes (Issues #59, #60, #61, #62, #63 #64) in the same branch -comments - remove duplicated library files and commented codes

jimhw commented 7 years ago

the branch is seemed to work after adding the kefir and kefir-bus packages. thanks

stacy-hunt commented 7 years ago

It fixes most of the issues, but we need to fine-tune some of the animations. I'll have a play with the prototype and see if I can get it the way I want it. I think we should sign this card off as complete and I'll create a new one for the final polishing of the animations once I have worked out how I think they should work.

kolbinski commented 7 years ago

Task is ready for tests on production

kolbinski commented 7 years ago

Task was tested by @stacy-hunt on production