LunchDevCommunity / community-calendar

📅 Community calendar for our Discord server, built with love and Eleventy.
https://events.lunch.dev
15 stars 12 forks source link

use computed data to provide derived calendar events to all events #38

Closed chantastic closed 3 years ago

chantastic commented 3 years ago

hey @roman-bytes!

I noticed that the latest iteration of your PR wasn't rendering correctly. I thought I'd take a quick stab at everything to understand how dat moves thru templates and content better. After some investigation, I think that Computed Data might be the way to handle this.

Computed Data is a way of injecting data for each page render of an event. With this method we get access to content data. We can the augment data from front matter.

I took your implementation and ported it to a Computed Data approach.

If this looks good to you and @BenDMyers, let's merge it into your branch then continue the broader implementation discussion.

closes #23 (thanks @msutkowski!)

chantastic commented 3 years ago

Please feel free to disregard, but might be helpful. This awesome. Any time we can use computed data, I'm sold. This also closes my idea of #23 — @msutkowski

😅 i like how your last comment was literally "inject into frontmatter"!

and yah, i think this largely resolves that question. the matter of how we style it still remains. on a technical side, I'm super curious how we could add a shared global check for has this event passed?