search

Luncher91 / VBScript-vscode

A vscode extension for VBScript language support
MIT License
20 stars 5 forks source link

ASP file support #13

Closed Luncher91 closed 4 years ago

Luncher91 commented 6 years ago

Commenter Scott Chapman on the Marketplace suggested ASP file support.

To fully support ASP files it is needed to detect the script parts of the ASP file.

jonathanstar commented 6 years ago

Is this in the works? This would be quite useful to me.

Luncher91 commented 6 years ago

I am currently not working on it, but you are very welcome to contribute :-)

Luncher91 commented 4 years ago

@kevinsproles Thank you very much for your pull request! @jonathanstar Can you please check if version 1.1.0 fullfills your needs?

jonathanstar commented 4 years ago

Thanks @kevinsproles and @Luncher91, this is great and is going to be helpful for me! One small thing I noticed is that symbols get out of wack when a sub/function doesn't have the end function keyword, and once they do it doesn't recalculate until the keypress after you type end function/end sub. check out the two screen shots below to see what I mean.

Before extra keypress the symbols in the outline are incorrect:

before_keypress

After extra keypress (in this case I hit return) the symbols on the right sort themselves out correctly:

after_keypress

The only other thing I'd say which would be awesome is if the symbols supported goto definition. Maybe I should make a separate feature request for that?

Luncher91 commented 4 years ago

Oh, yes it would be great if you could create an issue for the first for incorrect parsing - that looks like a general issue not specific to ASP files. And of yourse another one for your mentioned "goto" although I only know of the error handling routines containing "goto" - we can clarify that in the other thread.