search

Lundalogik / lime-elements

Provides reusable web components for Lime CRM
https://lundalogik.github.io/lime-elements/versions/latest
Other
38 stars 12 forks source link

Action menu icon incorrectly gets badge icon #1370

Closed anderssonjohan closed 2 years ago

anderssonjohan commented 2 years ago

Current behavior

Using the list component with an action menu and turning on badge icons also renders the action menu icon with a badge.

Screen Shot 2021-09-29 at 19 23 45

The margin to the list item text is also a bit messed up.

Screen Shot 2021-09-29 at 19 29 30

This selector seems to be the issue: https://github.com/Lundalogik/lime-elements/blob/91998a83ed3ff47728f2ae02a3b734545372eaa4/src/components/list/list.scss#L70-L81

Expected behavior

Using badgeIcons should only change the look of the list item icon, not the action menu icon.

Screen Shot 2021-09-29 at 19 23 58

Environment

anderssonjohan commented 2 years ago

Fixed by only selecting the list item graphic icon: limel-icon.mdc-deprecated-list-item__graphic

lime-ci commented 2 years ago

:tada: This issue has been resolved in version 33.13.0-next.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

lime-ci commented 2 years ago

:tada: This issue has been resolved in version 33.13.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: