Lundalogik / lime-elements

Provides reusable web components for Lime CRM
https://lundalogik.github.io/lime-elements/versions/latest
Other
38 stars 12 forks source link

limel-icon: add support for displaying images #2875

Closed adrianschmidt closed 3 months ago

adrianschmidt commented 4 months ago

fix: #2874 fix: https://github.com/Lundalogik/hack-tuesday/issues/345

image

Result of playing around with this in the limel-chip-set composite example.

Review:

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

Linux:

macOS:

Mobile:

github-actions[bot] commented 4 months ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2875/

adrianschmidt commented 4 months ago

Question from Tommy during hack-demos: what if the image doesn't load, do we get a broken image icon?

Probably yes. But could we do something about that? It would be nice if the user just saw the icon instead if the image doesn't load… 🤷‍♂️

jgroth commented 4 months ago

This PR is already quite big, so I just wanted to mention that we don't have to fix everything in this PR to make it easier to review :smile:

adrianschmidt commented 4 months ago

This PR is already quite big, so I just wanted to mention that we don't have to fix everything in this PR to make it easier to review 😄

Good point 👍

I've started by breaking out the two first commits that are just doing some general boyscouting: https://github.com/Lundalogik/lime-elements/pull/2881 https://github.com/Lundalogik/lime-elements/pull/2882

Those should be fine to review and merge regardless of what happens to the rest of this.

hannahu commented 3 months ago

So this could be closed? Just to clarify when someone will review 😄

Kiarokh commented 3 months ago

I think so. Reopen if you disagree