Closed adrianschmidt closed 3 months ago
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2875/
Question from Tommy during hack-demos: what if the image doesn't load, do we get a broken image icon?
Probably yes. But could we do something about that? It would be nice if the user just saw the icon instead if the image doesn't load… 🤷♂️
This PR is already quite big, so I just wanted to mention that we don't have to fix everything in this PR to make it easier to review :smile:
This PR is already quite big, so I just wanted to mention that we don't have to fix everything in this PR to make it easier to review 😄
Good point 👍
I've started by breaking out the two first commits that are just doing some general boyscouting: https://github.com/Lundalogik/lime-elements/pull/2881 https://github.com/Lundalogik/lime-elements/pull/2882
Those should be fine to review and merge regardless of what happens to the rest of this.
So this could be closed? Just to clarify when someone will review 😄
I think so. Reopen if you disagree
fix: #2874 fix: https://github.com/Lundalogik/hack-tuesday/issues/345
Result of playing around with this in the limel-chip-set composite example.
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: