feat(editor): change default menu

Lundalogik / lime-elements

Provides reusable web components for Lime CRM

https://lundalogik.github.io/lime-elements/versions/latest

Other

38 stars 12 forks source link

feat(editor): change default menu #2904

Closed LawrenceBorst closed 4 months ago

LawrenceBorst commented 4 months ago

Fixes Lundalogik/crm-feature#4041 Fixes Lundalogik/crm-feature#4043

Review:

[ ] Commits are atomic
[ ] Commits have the correct type for the changes made
[ ] Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

[ ] Chrome
[ ] Edge
[ ] Firefox

Linux:

[ ] Chrome
[ ] Firefox

macOS:

[ ] Chrome
[ ] Firefox
[ ] Safari

Mobile:

[ ] Chrome on Android
[ ] iOS

github-actions[bot] commented 4 months ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2904/

john-traas commented 4 months ago

Any comments I would have would be around certain hard coded values and indexing. That would stem from using some of the pre-built examples that prosemirror have, and which we've decided to use to implement the first version of the text editor.

For that reason I feel good about approving this PR. We can iterate further on this as we build it out.

lime-opensource commented 4 months ago

:tada: This PR is included in version 37.18.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: