feat(select): enable separators in dropdown list items

Lundalogik / lime-elements

Provides reusable web components for Lime CRM

https://lundalogik.github.io/lime-elements/versions/latest

Other

38 stars 12 forks source link

feat(select): enable separators in dropdown list items #2914

Closed Kiarokh closed 2 months ago

Kiarokh commented 2 months ago

fix https://github.com/Lundalogik/crm-feature/issues/4054

Review:

[ ] Commits are atomic
[ ] Commits have the correct type for the changes made
[ ] Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

[ ] Chrome
[ ] Edge
[ ] Firefox

Linux:

[ ] Chrome
[ ] Firefox

macOS:

[ ] Chrome
[ ] Firefox
[ ] Safari

Mobile:

[ ] Chrome on Android
[ ] iOS

github-actions[bot] commented 2 months ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2914/

Befkadu1 commented 2 months ago

I don't understand why the tests are failing? Any help?

adrianschmidt commented 2 months ago

I don't understand why the tests are failing? Any help?

Loads of tests seem to fail because some value is null. Could it be that the test code can no longer find the element in the page or something like that?

Befkadu1 commented 2 months ago

Loads of tests seem to fail because some value is null. Could it be that the test code can no longer find the element in the page or something like that?

Yea that is what happened but I don't understand why the changes we made caused the issue

lime-opensource commented 2 months ago

:tada: This PR is included in version 37.24.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: