Lundalogik / lime-elements

Provides reusable web components for Lime CRM
https://lundalogik.github.io/lime-elements/versions/latest
Other
38 stars 12 forks source link

feat(text-editor): implement label prop #2929

Closed Kiarokh closed 2 months ago

Kiarokh commented 2 months ago

Review:

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

Linux:

macOS:

Mobile:

github-actions[bot] commented 2 months ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2929/

adrianschmidt commented 2 months ago

I've read Kia's comment and quickly eyed over the PR. Concept-wise it gets the mark of approval from me. I have not tested anything or looked closely at the code changes. I'll leave that to someone from the text editor cycle team 😊

Good work! 🙌

LucyChyzhova commented 2 months ago

Together with readOnly and an empty composer, it looks strange Maybe we should improve the readOnly state - like to have opacity: 05 for the whole compose, so we see it somehow? 🤔

https://github.com/Lundalogik/lime-elements/assets/50618208/dfb0fbd6-fb3b-4f8d-9de7-1e9d5f785e6e

Kiarokh commented 2 months ago

Together with readOnly and an empty composer, it looks strange

Good point. We should do something similar to what we do in the input field.

image

But we can do it later in a follow up PR.

LucyChyzhova commented 2 months ago

We should do something similar to what we do in the input field.

Agree! I made an issue for it https://github.com/Lundalogik/crm-feature/issues/4079

lime-opensource commented 2 months ago

:tada: This PR is included in version 37.25.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: