search

Lundalogik / lime-elements

Provides reusable web components for Lime CRM
https://lundalogik.github.io/lime-elements/versions/latest
Other
38 stars 12 forks source link

feat(text editor): add explicit menu types #2940

Closed john-traas closed 1 month ago

john-traas commented 2 months ago

Fixes https://github.com/Lundalogik/crm-feature/issues/4084

github-actions[bot] commented 2 months ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2940/

john-traas commented 1 month ago

@civing @LawrenceBorst

I've simplified the current tests as I ran into some issues with mocking functions that make changes to the editor view state, the Dom and global selection in the tests. I'm working on it but I have a follow-up PR that refactors the prosemirror-adaptor to streamline it a bit more and I think we can add to the tests in that PR if need be.

Showing selected/active menu items and adding translations is also waiting on this PR.

lime-opensource commented 1 month ago

:tada: This PR is included in version 37.40.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: