Lundalogik / lime-elements

Provides reusable web components for Lime CRM
https://lundalogik.github.io/lime-elements/versions/latest
Other
38 stars 12 forks source link

fix(text-editor): ensure editor resizes with its container #2950

Closed Kiarokh closed 2 months ago

Kiarokh commented 2 months ago

and never grows taller or wider than its own container

Review:

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

Linux:

macOS:

Mobile:

github-actions[bot] commented 2 months ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2950/

civing commented 2 months ago

I get two scrollbars in that example you added 😕

https://github.com/Lundalogik/lime-elements/assets/4279390/a7ac0841-ed1c-4521-b4ea-38c072564b5b

Kiarokh commented 2 months ago

I get two scrollbars in that example you added 😕

hmmm...... good catch.... freaking bloody divs. I'm gonna check this again. Everything was working fine 😢

Also this has to be fixed:

image
lime-opensource commented 2 months ago

:tada: This PR is included in version 37.26.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: