perf(dock): avoid re-creating observer whenever menu is opened

[jgroth]

The intersection observer was re-created every time the button in the menu was clicked, causing the callback to be invoked multiple times

Review:

• [ ] Commits are atomic
• [ ] Commits have the correct type for the changes made
• [ ] Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

• [ ] Chrome
• [ ] Edge
• [ ] Firefox

Linux:

• [ ] Chrome
• [ ] Firefox

macOS:

• [ ] Chrome
• [ ] Firefox
• [ ] Safari

Mobile:

• [ ] Chrome on Android
• [ ] iOS

[hannahu]

Looks good! How can I test it?

[jgroth]

Looks good! How can I test it?

You can add a logpoint in the callback and see that it's only called once when a many is opened :upside_down_face: It will be invoked one more time for each time it's clicked without this fix

[hannahu]

Looks good! How can I test it?

You can add a logpoint in the callback and see that it's only called once when a many is opened 🙃 It will be invoked one more time for each time it's clicked without this fix

Yeah I was thinking if there was another way to test if it caused more trouble.

[hannahu]

Some docs are failing?

[github-actions[bot]]

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2982/

[lime-opensource]

:tada: This PR is included in version 37.40.1 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: