Fix text editor gets dirty - Githubissues

Lundalogik / lime-elements

Provides reusable web components for Lime CRM

https://lundalogik.github.io/lime-elements/versions/latest

Other

38 stars 12 forks source link

Fix text editor gets dirty #2999

Closed LawrenceBorst closed 1 month ago

LawrenceBorst commented 1 month ago

Fixes Lundalogik/crm-feature#4099

How to test:

I've done my best to test it. Here's what to look for.

Thinking of edge cases, there's only one, which is when the initial value is empty. Try and check if this has any strange behaviour.

Also, the save button should disappear when the value goes back to what it originally was. So if your text editor says "some sentence", and you edit it to something else, and then back to "some sentence", we should not see the save button.

We believe the cause of the original bug was the fact that the default content type was changed from "html" to "markdown". To test, try and change the content type in the card component in lime admin and see if the bug persists.

Make sure saving continues to work as expected.

Review:

[ ] Commits are atomic
[ ] Commits have the correct type for the changes made
[ ] Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

[ ] Chrome
[ ] Edge
[ ] Firefox

Linux:

[ ] Chrome
[ ] Firefox

macOS:

[ ] Chrome
[ ] Firefox
[ ] Safari

Mobile:

[ ] Chrome on Android
[ ] iOS

github-actions[bot] commented 1 month ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2999/

adrianschmidt commented 1 month ago

FYI: I squashed the existing fixup, and rebased on what's currently the latest main.

john-traas commented 1 month ago

This looks really clean and seemed to work well when I tested it.

lime-opensource commented 1 month ago

:tada: This PR is included in version 37.45.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: