Lundalogik / lime-elements

Provides reusable web components for Lime CRM
https://lundalogik.github.io/lime-elements/versions/latest
Other
38 stars 12 forks source link

Convert menu handling to plugins #3000

Closed john-traas closed 1 month ago

john-traas commented 1 month ago

There's a risk of the prosemirror adapter becoming too heavy with different parts of the text editor being too tightly coupled.

We should adopt the same approach for extending the adaptor as we do for menu-state tracking, via plugins. This is the way prosemirror expects us to do it and it enables us to keep a good separation of concerns allowing for future development of this tool as and when it's needed.

This PR extracts the menu-state-tracking to a standalone plugin and does the same for handling interactions with the action bar items.

Fixes https://github.com/Lundalogik/crm-feature/issues/4135

How to test

github-actions[bot] commented 1 month ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3000/

lime-opensource commented 1 month ago

:tada: This PR is included in version 37.48.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: