feat(text editor): handle keyboard navigation for link menu

Lundalogik / lime-elements

Provides reusable web components for Lime CRM

https://lundalogik.github.io/lime-elements/versions/latest

Other

38 stars 12 forks source link

feat(text editor): handle keyboard navigation for link menu #3017

Closed john-traas closed 3 weeks ago

john-traas commented 4 weeks ago

Tabbing within the link menu no longer closes the menu
Hitting enter will save the link
Hitting escape will close the link menu

Fixes https://github.com/Lundalogik/crm-feature/issues/4164

github-actions[bot] commented 4 weeks ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3017/

john-traas commented 3 weeks ago

Code looks good. I found one issue, when clicking on a link, backspacing, and pressing enter, sometimes it does not alter the link at all

Enregistrement.de.l.ecran.2024-06-05.a.10.52.29.mov

It certainly seems to be tied to a race condition. I think it has to do with the way changes to the link are handled.

changes to the link are emitted by the link-menu
those changes are caught by the prosemirror-adapter and passed back to the link-menu
the link-menu updates
the handle save function can emit the save event before the above chain of events has completed

Kiarokh commented 3 weeks ago

@john-traas I made this one a draft, in favor of https://github.com/Lundalogik/lime-elements/pull/3023 I think we can bring the necessary parts from this PR to the other one. I think we should also ignore that delegateFocus problem for now to be able to move on. This now offers the basic keyboard navigation needs. We can delegate focus later.

john-traas commented 3 weeks ago

@john-traas I made this one a draft, in favor of #3023 I think we can bring the necessary parts from this PR to the other one. I think we should also ignore that delegateFocus problem for now to be able to move on. This now offers the basic keyboard navigation needs. We can delegate focus later.

@Kiarokh and @LawrenceBorst I've cherry-picked the changes we need from this PR and pushed them to a commit in the new PR. I'll close this PR as we'll only need to merge the other one.