search

Lundalogik / lime-elements

Provides reusable web components for Lime CRM
https://lundalogik.github.io/lime-elements/versions/latest
Other
38 stars 12 forks source link

fix(text-editor): ensure link popover opens in a decent location #3022

Closed Kiarokh closed 3 weeks ago

Kiarokh commented 3 weeks ago

fix https://github.com/Lundalogik/crm-feature/issues/4169

Review:

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

Linux:

macOS:

Mobile:

github-actions[bot] commented 3 weeks ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3022/

john-traas commented 3 weeks ago

This seems to introduce some strange behaviour to the editor-link-menu.

https://github.com/Lundalogik/lime-elements/assets/122509723/2d23ba64-ac9d-4114-9fb9-63e86868b828

LucyChyzhova commented 3 weeks ago

This seems to introduce some strange behaviour to the editor-link-menu.

Screen.Recording.2024-06-07.at.13.16.11.mov

yes, it what I noticed as well check the comment, but actually that behaviour was not introduced here, this bug is a portal bug which we already had.

Kiarokh commented 3 weeks ago

This seems to introduce some strange behaviour to the editor-link-menu.

Screen.Recording.2024-06-07.at.13.16.11.mov

Yes. Gonna solve this separately. We have the same issue on main. Seems to be a limel-portal but https://github.com/Lundalogik/crm-feature/issues/4170

lime-opensource commented 3 weeks ago

:tada: This PR is included in version 37.49.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Kiarokh commented 3 weeks ago

additional not:

In the real app, this will "almost" never happen. This is because the text editor will never (or should never) be as tall as the screen itself. However, we need to mitigate this issue from the component as well:

https://github.com/Lundalogik/crm-feature/issues/4171

john-traas commented 3 weeks ago

Emails in a chain of replies can get quite long. I think in the email story this could happen quite easily?

LucyChyzhova commented 3 weeks ago

yes, for sure. We are aware of this case