Lundalogik / lime-elements

Provides reusable web components for Lime CRM
https://lundalogik.github.io/lime-elements/versions/latest
Other
38 stars 12 forks source link

feat(limel-text-editor): remove native url validation from the link input field #3030

Closed LawrenceBorst closed 3 weeks ago

LawrenceBorst commented 3 weeks ago

Fixes Lundalogik/crm-feature#4166

How to Test

Go into one of the limel prosemirror adapter examples and add a link. Now try writing "test" -> hit tab -> writing "test". Then click outside the input field and note that it does not turn red (before the problem was that a phrase like "test" was not considered a valid URL).

Review:

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

Linux:

macOS:

Mobile:

github-actions[bot] commented 3 weeks ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3030/

LawrenceBorst commented 3 weeks ago

Merging now (despite accessibility concerns) as we intend to release the latest editor ASAP due to it being publicly available in quick note.

lime-opensource commented 3 weeks ago

:tada: This PR is included in version 37.52.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: