Lundalogik / lime-elements

Provides reusable web components for Lime CRM
https://lundalogik.github.io/lime-elements/versions/latest
Other
38 stars 12 forks source link

fix(table): prevent rendering rows with very short height #3034

Closed Kiarokh closed 3 weeks ago

Kiarokh commented 3 weeks ago

The table component dynamically adds inline styles such as height to its rows and cells. The height is added in px, and is calculated based on the content of the cells. In some scenarios where the cells have no content or hold web-components that load with delay, after the table is rendered, the dynamic inlined height styles used to be calculated very strangely, causing the rows and cells to be very short height. This change will prevent these things, by applying a proper default min-height.

Review:

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

Linux:

macOS:

Mobile:

github-actions[bot] commented 3 weeks ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3034/

lime-opensource commented 3 weeks ago

:tada: This PR is included in version 37.52.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: