Lundalogik / lime-elements

Provides reusable web components for Lime CRM
https://lundalogik.github.io/lime-elements/versions/latest
Other
38 stars 12 forks source link

Fix date picker custom formatter called with extra args #3041

Closed vicgeralds closed 1 week ago

vicgeralds commented 2 weeks ago

The date formatter function used with the date picker was called lots of times, and sometimes directly by flatpickr that passed its extra args format and locale.

Now we only call the custom formatter to format the value of the date picker, passing only the value argument, and not for formatting aria labels that flatpickr sometimes renders for pickable dates.

Also updates the value of a closed date picker when set programmatically

fixes: Lundalogik/crm-feature/issues/3182

Review:

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

Linux:

macOS:

Mobile:

github-actions[bot] commented 2 weeks ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3041/

lime-opensource commented 1 week ago

:tada: This PR is included in version 37.53.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: