Fix table update data - Githubissues

Lundalogik / lime-elements

Provides reusable web components for Lime CRM

https://lundalogik.github.io/lime-elements/versions/latest

Other

38 stars 12 forks source link

Fix table update data #3050

Closed vicgeralds closed 1 week ago

vicgeralds commented 1 week ago

Avoids scrolling the table when updating existing rows with new data.

If no rows are removed, we can call tabulator.updateOrAddData which apparently works better than replaceData when we want don't the scrolling position to change.

To make this work with active row and selection, rows are tracked by id when available. Tabulator supports indexing data by an id property, which by default is id: https://tabulator.info/docs/6.2/data#row-index

Fixes: https://github.com/Lundalogik/crm-feature/issues/3925

Review:

[ ] Commits are atomic
[ ] Commits have the correct type for the changes made
[ ] Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

[ ] Chrome
[ ] Edge
[ ] Firefox

Linux:

[ ] Chrome
[ ] Firefox

macOS:

[ ] Chrome
[ ] Firefox
[ ] Safari

Mobile:

[ ] Chrome on Android
[ ] iOS

github-actions[bot] commented 1 week ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3050/

lime-opensource commented 1 week ago

:tada: This PR is included in version 37.53.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: