search

Lundalogik / lime-elements

Provides reusable web components for Lime CRM
https://lundalogik.github.io/lime-elements/versions/latest
Other
38 stars 11 forks source link

fix(text editor): ensure the link menu is correctly displayed #3059

Closed john-traas closed 3 months ago

john-traas commented 3 months ago

The z-index being set on the lime portal rendered from the prosemirror adaptor was incorrect and causing the link menu to be rendered behind other elements.

Fixes https://github.com/Lundalogik/crm-feature/issues/4215

github-actions[bot] commented 3 months ago

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3059/

Kiarokh commented 3 months ago

a nitpicky thing, but please change the commit message: fix(link menu): remove errant z-index style

to something like: fix(text-editor): ensure the link menu is correctly displayed

link menu (or more correctly written as a scope in a commit message: text-editor-link-menu) is a private component. It means consumers shouldn't even know or care it exists. So the scope for the consumer is text-editor, because that's where they see and experience the fix. We never use @private components as the scope.

Also, unless the change is refactor or chore, we should try to explain what kind of buggy behavior has been fixed, or what kind of feature-y thing has been added.

Then the commit message can have the details, such as it was about a crazy z-index or whatever, which caused X or Y.

lime-opensource commented 3 months ago

:tada: This PR is included in version 37.53.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: