search

Lundez / JavaSymSpell

SymSpell v6.4ish ported to Java 8. Will be a module in my Master Thesis.
MIT License
22 stars 13 forks source link

Update to SymSpell 6.3 #8

Closed loretoparisi closed 5 years ago

loretoparisi commented 5 years ago

Any plan to update this release to latest SymSpell version? The v6.4 has introduced important changes most of them related to the new WordSegmentation. A minor change to maxEditDistance to speed up lookup.

Thank you.

Lundez commented 5 years ago

Hello Loreto!

I'll take a look at it this weekend and hopefully have it implemented by Sunday. :)

Best regards, Hampus (Londet)

Den sön 18 nov. 2018 18:50 skrev Loreto Parisi notifications@github.com:

Any plan to bump release to latest SymSpell? The v6.4 has introduced https://github.com/wolfgarbe/SymSpell#changes-in-v63 important changes most of them related to the new WordSegmentation. A minor change to maxEditDistance to speed up lookup.

Thank you.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Lundez/JavaSymSpell/issues/8, or mute the thread https://github.com/notifications/unsubscribe-auth/AHJKlyj3XPdPoKjN71F5gFox92Qwe38Yks5uwZ35gaJpZM4YoDct .

Lundez commented 5 years ago

Update: I've started to look into it, it'll be some work to actually find where to change the java-version as they're not completely identical in how code is structured. I don't think I'll be finished this sunday anymore unfortanely. But I'll try to wrap it up asap!

loretoparisi commented 5 years ago

@Lundez thanks for the details! 🥇

Lundez commented 5 years ago

Hi, I just uploaded a 'beta' version directly on top of master as the changes won't make any difference to the core-code.

The code should be "finished", but I believe there is some minor issues to pan out..

It contains both changes you wanted the most 👍

loretoparisi commented 5 years ago

@Lundez thank you so much to be so fast! I will merge my code in dev and try it out! Closing then.