search

Luodian / Otter

🦦 Otter, a multi-modal model based on OpenFlamingo (open-sourced version of DeepMind's Flamingo), trained on MIMIC-IT and showcasing improved instruction-following and in-context learning ability.
https://otter-ntu.github.io/
MIT License
3.52k stars 241 forks source link

`gradio_web_server` is outdated #323

Closed StrangeTcy closed 5 months ago

StrangeTcy commented 7 months ago

https://github.com/Luodian/Otter/blob/8b386816ec67b15833cde3dcd1d7ca6a752d2451/pipeline/serve/gradio_web_server.py#L16 -- this no longer works since pipeline.constants doesn't exist. But LOGDIR is defined in https://github.com/Luodian/Otter/blob/8b386816ec67b15833cde3dcd1d7ca6a752d2451/pipeline/serve/serving_utils.py#L11

ETA: gradio_patch starts with a comments saying Adopted from https://github.com/gradio-app/gradio/blob/main/gradio/components.py, and gradio/components.py doesn't exist. Nor does gradio/components/components.py

ETA: Ah, yes, pipeline/serve/examples doesn't exist either

Luodian commented 6 months ago

hi you could take a look at model_serving branch:

https://github.com/Luodian/Otter/tree/model_serving/pipeline/serve/examples

Your suggestions on code polish is quite good and I will definitely take them to refine our code. Current issue is due to the shift from previously Otter's serving method into OtterHD's serving method.