Luohuayu / CatServer

高性能和高兼容性的1.12.2/1.16.5/1.18.2版本Forge+Bukkit+Spigot服务端 (A high performance and high compatibility 1.12.2/1.16.5/1.18.2 version Forge+Bukkit+Spigot server)
https://catmc.org
GNU Lesser General Public License v3.0
1.98k stars 211 forks source link

[1.16.5] withUnderlined using official mappings is a NoSuchMethodError #614

Closed VOrlando520 closed 1 year ago

VOrlando520 commented 2 years ago

Environment

Minecraft version(1.12.2/1.16.5/1.18.2): 1.16.5 Build version(Get from /version command): c9bc6751 Mods/Plugins:

Plugins - https://pastebin.com/k66NYjf6 Mods - Pixelmon 9.0.8

Describe the bug On Minecraft 1.16.5, a Forge mod that calls "Style#setUnderlined(Boolean)" using official mappings (so it maps the function to func_244282_c) throws NoSuchMethodError. It works fine on a Forge environment"

https://pastebin.com/U59zeLRz

Expected behavior Running a command that calls on that function to open gui, run command, etc.

To Reproduce Use any plugin that calls upon that function and it will crash/cause an NPE

Screenshot/Video (If it doesn't exist you can ignore it)

Kotori0629 commented 2 years ago

@OnlyIn(Dist.CLIENT) public Style withUnderlined(@Nullable Boolean p_244282_1_)

VOrlando520 commented 2 years ago

Is this meant to be fixed client side or is it a more in depth fix in catserver itself?

Kotori0629 commented 2 years ago

Please package plugins and mods

VOrlando520 commented 2 years ago

Use that code that you pasted within plug-ins and mods or you want me to upload my plug-ins and mods here?

Kotori0629 commented 2 years ago

Use that code that you pasted within plug-ins and mods or you want me to upload my plug-ins and mods here?

Yes, upload your plugins & mods

VOrlando520 commented 2 years ago

Sorry, there are some custom things in there that I wont upload here for everyone to download and use. Those are the same plugins that are having issue stated above.

Kotori0629 commented 2 years ago

Sorry, there are some custom things in there that I wont upload here for everyone to download and use. Those are the same plugins that are having issue stated above.

Only the mod/plugin that reports the error is required

Kotori0629 commented 1 year ago

You should contact the plugin author, please do not call methods annotated with OnlyIn(Dist.CLIENT)