Unknown query strategy "greedy_boxbadge"

Coolshanlan commented 1 year ago

Hi, thanks for your nice work. I have the following problem when training with pv_rcnn_active_crb.yaml on kitti dataset

2023-05-03 12:11:58,126   INFO  **********************Start training active-kitti_models/pv_rcnn_active_crb(select-1
00)**********************
2023-05-03 12:11:58,127   INFO  ***** Start Active Pre-train *****
2023-05-03 12:11:58,181   INFO  **init backbone weights saved...**
train: 100%|███████████████████████████████████████████████████████████████████████████████████████████████| 50/50 [
00:16<00:00,  3.07it/s, total_it=2000]
epochs: 100%|███████████████████████████████████████████████████████████████████████████████████████| 40/40 [11:00<0
0:00, 16.51s/it, loss=1.5, lr=1.69e-7]
2023-05-03 12:22:58,595   INFO  ***** Complete Active Pre-train *****
2023-05-03 12:22:58,602   INFO  ***** Start Active Train Loop *****
epochs:   0%|
              | 0/240 [00:00<?, ?it/s]
Traceback (most recent call last):
  File "train.py", line 313, in <module>
    main()
  File "train.py", line 231, in main
    train_func(
  File "/home/coolshan/Project/CMLAB/3d_active_learning/CRB-active-3Ddet/tools/train_utils/train_active_utils.py", l
ine 302, in train_model_active
    = active_training_utils.select_active_labels(
  File "/home/coolshan/Project/CMLAB/3d_active_learning/CRB-active-3Ddet/tools/../pcdet/utils/active_training_utils.
py", line 252, in select_active_labels
    strategy = query_strategies.build_strategy(method=method, model=model, \
  File "/home/coolshan/Project/CMLAB/3d_active_learning/CRB-active-3Ddet/tools/../pcdet/query_strategies/__init__.py
", line 28, in build_strategy
    raise KeyError("Unknown query strategy:", method)
KeyError: ('Unknown query strategy:', 'greedy_boxbadge')

I can't find the greedy_boxbadge strategy in query_strategies/__init__.py too.

__factory = {
    'random': RandomSampling,
    'entropy': EntropySampling,
    'badge': BadgeSampling,
    'coreset': CoresetSampling,
    'llal': LLALSampling,
    'montecarlo': MonteCarloSampling,
    'confidence': ConfidenceSampling,
    'crb': CRBSampling
}

Is there something I'm missing here or an installation error? or how can I fixed. Thanks

Luoyadan commented 1 year ago

Hi, Could you please rename the method name to 'crb' in this cfg file: https://github.com/Luoyadan/CRB-active-3Ddet/blob/9af7e973892930e7244700b337c9ad0179f27824/tools/cfgs/active-kitti_models/pv_rcnn_active_crb.yaml#L249

We changed the method names multiple times and the greedy_boxbadge is an old name. Sorry for the inconvenience. Cheers, Yadan

Coolshanlan commented 1 year ago

thanks, it works.

Luoyadan / CRB-active-3Ddet

Unknown query strategy "greedy_boxbadge" #5