Closed edbennett closed 5 months ago
@nickforce989 Can you look at this next, please? I think this shouldn't take you longer than an hour.
@edbennett, yes I will look into this as next issue.
Before closing this, run pre-commit run --all
and commit any fixes that it suggests.
(Note that if you think a commit will fix an issue, you can use the literal text fixes #number
or fix #number
or closes #number
in the commit message and it will happen automatically. I'd recommend only using this in a branch so that the changes can be reviewed a pull request before the issues gets automatically closed.)
Done!
I'd recommend using 5–10 words to describe the issue being fixed rather than just referencing an issue number, for the benefit of those reading the git log
in future who may not have the GitHub up.
I'd suggest using
ruff format
to automatically reformat the code in a standard style, and then impose this style on all future commits with apre-commit
hook.