search

Luracast / Laravel-Database

Laravel database for your non laravel projects. Built on top of illuminate/database to provide migration, seeding and artisan support
85 stars 12 forks source link

Abide by Laravel's config contract and utilize Laravel's config facade #7

Closed devonbessemer closed 6 years ago

devonbessemer commented 7 years ago

Great package, but I saw one inconsistency with the Config class being used. Maybe you had your reasons but, I think for most, it would be best to abide by Laravel's Config contract which also makes you able to use Laravel's Config facade.

MarcinOrlowski commented 7 years ago

Why isn't this merged? Any reason to not have Config?

Arul- commented 7 years ago

@MarcinOrlowski thanks for the reminder, I need to test this for all use cases

ronappleton commented 6 years ago

@MarcinOrlowski nice job there. @Arul- Any chance of seeing this included soon, would be real nice to adhere to Laravels config contract?

Arul- commented 6 years ago

Done at last. Sorry for the delay!