search

Luracast / Laravel-Database

Laravel database for your non laravel projects. Built on top of illuminate/database to provide migration, seeding and artisan support
85 stars 12 forks source link

Upgraded the Laravel-Database to 5.8.* #9

Closed abhishek70 closed 5 years ago

abhishek70 commented 5 years ago

Hi @Arul- ,

I was able to upgrade the Laravel-Database to 5.8.* by keeping the current folder structure same. I have tested on my end and its working as expected.

Whenever you have a chance can you please take a look at the changes : https://github.com/abhishek70/Laravel-Database/tree/Laravel-Database-5.8 and provide your feedback and suggestions regarding any changes.

If you want I can also create a pull request if that helps.

Thank you, Abhishek

Arul- commented 5 years ago

Can you make a pull request here, I will test and approve it

abhishek70 commented 5 years ago

Sure. Thanks

Arul- commented 5 years ago

Fixed in https://github.com/Luracast/Laravel-Database/pull/10

Arul- commented 5 years ago

I have also upgraded https://github.com/Luracast/Restler-Application with your contribution :)

Arul- commented 5 years ago

Now _ide_helper.php is the only file that is out of date!

abhishek70 commented 5 years ago

Now _ide_helper.php is the only file that is out of date!

Yeah. I will take a look at generating it using https://github.com/barryvdh/laravel-ide-helper.

Arul- commented 5 years ago

https://github.com/barryvdh/laravel-ide-helper/issues/756 will help

Arul- commented 5 years ago

I just added IDE Helper support :)

I did it as a thank you for your contribution!

I had to include queue and files otherwise it was creating so many issues so I added them under dev requirements

abhishek70 commented 5 years ago

Great. I will pull the changes into my branch. Thank you @Arul- .

Arul- commented 5 years ago

As a bonus now we have the queue also available lazy loaded!