search

Luracast / Restler

Simple and effective multi-format Web API Server to host your PHP API as Pragmatic REST and/or RESTful API
http://luracast.com/products/restler/
GNU Lesser General Public License v2.1
1.36k stars 315 forks source link

Adding "bulk" API setters for API & Auth classes & changing Guzzle pkg name #555

Closed roynasser closed 8 years ago

roynasser commented 8 years ago

These functions provide better performance (in dev & production modes) when used in a scenario where there are many API classes (100-200+).

Code by @luracast I just added comments and made this PR.

Arul- commented 8 years ago

Lets keep it one pull request per purpose. Make another pull request for guzzle update

roynasser commented 8 years ago

As you can see from the commits and dates, it was by mistake @Arul- ... I didnt realize it would be adding into the same one since I had already merged the previous commit on my branch...

The main issue (breaking) is the first commit... the guzzle is just a warning (for now)...

Feel free to delete one of the commits if you think its a problem - I only changed composer.json in the second one, as guzzle v3 is still namespace guzzle.

I will look into upgrading guzzle in another PR if there arent too many impacts. So my mistake, feel free to either merge both or just delete the guzzle commit and I will submit a full "guzzle upgrade" PR in the coming weeks.

Arul- commented 8 years ago

Whatever you commit in a branch (master in this case) will be included in the pull request. That's how the second commit made it into this pull request. I wont be able to remove it from your repository, you have to do that yourself. Once I merge the first commit, you can push the second one