PHP has reserved all method names with a double underscore prefix for future use

Luracast / Restler

Simple and effective multi-format Web API Server to host your PHP API as Pragmatic REST and/or RESTful API

http://luracast.com/products/restler/

GNU Lesser General Public License v2.1

1.36k stars 315 forks source link

Closed gnouet closed 3 years ago

gnouet commented 5 years ago

Hi,

PHP has reserved all method names with a double underscore prefix for future use. There is five methods impacted :

If we rename all method to remove double underscore, it will introduce breaking change. But as it impacts interfaces, I do not see any good solution.

Is this a change that can be considered? I did a little test that could become a merge request.

gnouet commented 5 years ago

I created a PR in this sense. https://github.com/Luracast/Restler/pull/616 Thanks for your feedback !

Arul- commented 5 years ago

We need to apply this fix on RC5 and RC6 without affecting existing users on lower PHP versions

I'm still thinking about how to version this. I don't think we can call it RC5.1 and RC6.1

Once it is feature complete it will be released here.

Your ideas are welcome!

Arul- commented 3 years ago

Restler 4, and 5 (formally RC5 and RC^) won't have this change. Only restler 6 will have it