Frosthaven party sheet missing

ericvoshall commented 1 year ago

Hi, we were testing out Gloomhaven Secretary for a new Frosthaven campaign and noticed the party sheet is the Gloomhaven one not the Frosthaven one - any plans to update?

Lurkars commented 1 year ago

Yes, it will come definitely. Have to check how much it will take to add it, so no concrete ETA by now, but I am talking about next days or next weeks...

ericvoshall commented 1 year ago

Semi-related, but are there any bugs or features I would be able to submit a PR for to help out on for this project?

Lurkars commented 1 year ago

Semi-related, but are there any bugs or features I would be able to submit a PR for to help out on for this project?

Thanks for providing help. I do not have special roadmaps to delegate some work. In general the most lacking thing is just the boring data, which is not really development. But if you have time, take a look at Frosthaven Scenarios missing the room/rules data and just try to provide it.

To topic: I started preparation for the FH sheet. So will hopefully not take too long.

Lurkars commented 1 year ago

Screenshot from 2023-02-08 20-20-12

I am making some progress here! Hope to finish this on weekend, but no promises!

Lurkars commented 1 year ago

Current Frosthaven Campaign Sheet

Will be published today or tomorrow. Will need some proper testing and feedback, because I only know all this stuff from the rule book (Don't own FH yet), so maybe some stuff will be not completely correct to track.

But yes, it's ready, just need some fine tuning and currently I am working on the mechanic to move character resources (from the character sheet) to FH supply!

Lurkars commented 1 year ago

By the way: will it be useful to implement the town guard deck? I know nothing about all those mechanics yet. So selecting perks currently has no effect!

Lurkars commented 1 year ago

Implemented now with v0.45.0. Please test and give feedback if everything is working as expected. Some Infos:

because I still like the old campaign view for seeing scenarios, prosperity and donations, the sheet is still flippable as before with this view, so the prosperity and retirements are not on the initial sheet, click on the title "Campaign Sheet" to change dialog
Retirements now implemented (for all edition), so if you mark a chars personal quest as done, char will retire and added to the retirements list
stickers can be add by just typing the title in (as in screenshot: "friends of the icespeakers" or "Friend of the Icespeakers" would all work to add the sticker there, if text is unknown, the entered text will be added instead of sticker, so no validation (because I also don't know if all stickers are correct, if there's more etc)
to move resources from a char to Frosthaven supply, use the character's sheet, where a "Move to Frosthaven supply" button is located on Resources to open menu to move resources
I forgot to add many of the undo-texts, so currently many changes will show as placeholder label in undo menu, will be fixed

ericvoshall commented 1 year ago

Awesome, thank you! I will test this out. Does the calendar on the FH sheet support adding section numbers to the days?

Lurkars commented 1 year ago

Awesome, thank you! I will test this out. Does the calendar on the FH sheet support adding section numbers to the days?

As mentioned, I only know basics from rulebook. So honestly I don't know what you mean, or better: that this should be possible. So please just test it and collect all things missing/wrong and give feedback here. Then I can try to implement/fix stuff.

ericvoshall commented 1 year ago

Okay, will do. Thank you!

UChess1986 commented 1 year ago

By the way: will it be useful to implement the town guard deck? I know nothing about all those mechanics yet. So selecting perks currently has no effect!

Yes, that would be very useful!

For additional feedback, it would be cool if after the party goes back to frosthaven a new checkmark gets added automatically on the season part of the campaign sheet as well as updated inspiration.

Lurkars commented 1 year ago

Awesome, thank you! I will test this out. Does the calendar on the FH sheet support adding section numbers to the days?

Just added this functionality now by double click (long press on mobile) on a week!

Doctawin commented 1 year ago

The campaign sheet looks awesome. It works fine on a computer, but some of the fields (supply values, inspiration, defense) aren't displaying correctly on an iPad: Screenshot 2023-02-12 at 7 51 57 AM

Lurkars commented 1 year ago

I changed font-size and hope that fixes the IPad issue. I cannot test myself sadly. If you're able to debug the browser session on Ipad, I am pretty sure it is bound to font-size!

UChess1986 commented 1 year ago

I changed font-size and hope that fixes the IPad issue. I cannot test myself sadly. If you're able to debug the browser session on Ipad, I am pretty sure it is bound to font-size!

I just tested on Iphone it looks better

Lurkars commented 1 year ago

I just tested on Iphone it looks better

But still not fitting... Will try to increase height of element in next iteration

Doctawin commented 1 year ago

I just tested on Iphone it looks better

But still not fitting... Will try to increase height of element in next iteration

I can confirm that it looks better on iPad. The inspiration and defense values fully show now, but there's not enough vertical space for the supply values. So, it looks similar to the above screenshot.

Lurkars commented 1 year ago

So in v0.45.5 I now increased the size of the input field. As sad, sadly I cannot test on Apple devices, so I hope it looks better now.

The "campaign sticker" area is now smaller on purpose, because the Town Guard Deck will move next to it in future!

UChess1986 commented 1 year ago

Its looking great! Tested on iphone

Doctawin commented 1 year ago

Also looks great on iPad. Thanks!

Lurkars commented 1 year ago

So besides Town Guard Deck (which isn't really part of the campaign sheet), are there any features missing/issues with current feature? Otherwise please close this issue @ericvoshall if it is solved for you this way now.

UChess1986 commented 1 year ago

So besides Town Guard Deck (which isn't really part of the campaign sheet), are there any features missing/issues with current feature? Otherwise please close this issue @ericvoshall if it is solved for you this way now.

It looks pretty complete so far, for the retired characters we just use the notes section on the regular campaign sheet right?

Lurkars commented 1 year ago

because I still like the old campaign view for seeing scenarios, prosperity and donations, the sheet is still flippable as before with this view, so the prosperity and retirements are not on the initial sheet, click on the title "Campaign Sheet" to change dialog

Retirements now implemented (for all edition), so if you mark a chars personal quest as done, char will retire and added to the retirements list

The retirement list is in the "backside", click on the title "campaign sheet" with the arrow on top to access it. Retirements only visible if you have one. To migrate existing sheet, just add character, fill out character sheet and mark personal quest as done! Then it should appear on retirement list!

sahilthapar commented 1 year ago

Awesome, thank you! I will test this out. Does the calendar on the FH sheet support adding section numbers to the days?

Just wanted to bring this up again with some clear details. I can create a new feature request for it if needed.

The calendar in Frosthaven is used to track the passage of time. (See attached image below) Each box denotes a week of time that has passed. Some of the boxes come filled with Section Book numbers that the party has to read when they mark that box off. By default I believe these are every 5 scenarios (or weeks).

Over the course of the game, many events will ask you to add section numbers in those boxes to be read at a future time. It would be good, if we could "pencil in" (fill in) those boxes. So in essence, it changes the box from a simple toggle / checkbox to a text field that can also be checked off.

Lurkars commented 1 year ago

Awesome, thank you! I will test this out. Does the calendar on the FH sheet support adding section numbers to the days?

Just added this functionality now by double click (long press on mobile) on a week!

Adding sections to weeks is already implemented!

sahilthapar commented 1 year ago

Thanks, somehow I missed that. Maybe scrolled past it too quickly.

Lurkars commented 1 year ago

New additions to the sheet will be filed in new issues, so I will close this one now as complete.

Lurkars commented 1 year ago

Town Guard Deck is also added a few version ago (since v0.65.4). It's available on the campaign sheet as slider:

Screenshot from 2023-05-23 21-33-05

Perks are already supported. What's missing by now is as I see that some section/rewards or so also add cards to this, this is currently missing. Also keep in mind, that drawing is only possible when not playing a scenario. And maybe it need to be shuffled manually, haven't re-read the rules yet, how it completely works.

Lurkars / gloomhavensecretariat

Frosthaven party sheet missing #107