Lurkars / gloomhavensecretariat

A Gloomhaven / Frosthaven Companion App
https://gloomhaven-secretariat.de
GNU Affero General Public License v3.0
181 stars 70 forks source link

Problem switching language #177

Closed alexkazik closed 1 year ago

alexkazik commented 1 year ago

how to reproduce:

Lurkars commented 1 year ago

There are several settings, that don't get synced currently. Those are all UI/UX settings, that don't affect actual gameplay so they will be kept individual per client. Those are:

So in general, I am wondering a bit about this, because locale just shouldn't sync

now the language in the settings has changed but the actual translation is the same as before

Are you using an old client? Because what I wrote above changed a few releases ago

alexkazik commented 1 year ago

Since a force reload the problem is gone - so probably an older version (browser tab was open for a while).

Tanks for the great tool!

And wise decision to not synchronize all that - though locale may be a good choice. I play in one group english Frosthaven and in another german JotL, so even though I have no problem with either language, it's easier to have the app in the same language as the physical game.

Lurkars commented 1 year ago

Mhm yeah I will think about this. By now I would agree that your use case is more common, than that a group want to play with different language interfaces, so I am tending to change that behaviour back.

Lurkars commented 1 year ago

Please re-test your issue with v0.53.4, locale should now be synced on correct applied on change.

alexkazik commented 1 year ago

Works like a charm!