Lurkars / gloomhavensecretariat

A Gloomhaven / Frosthaven Companion App
https://gloomhaven-secretariat.de
GNU Affero General Public License v3.0
181 stars 70 forks source link

Make settings independent from editions #368

Open mentonin opened 1 year ago

mentonin commented 1 year ago

Is your feature request related to a problem? Please describe.

When changing editions, many settings also change, even when they are manually set.

Describe the solution you'd like

Most settings that are edition dependent should have a specific auto/default option. For example, Theme should be GH/FH/Auto, and don't change when editions change unless set to auto. This is also valid for action style, loot deck, ally deck, battle goal amount.

Describe alternatives you've considered

None

Additional context

No response

mentonin commented 1 year ago

Settings that I think could be improved by this:

Frosthaven Rules -> House Rules:

Interface:

Lurkars commented 1 year ago

Thanks for the additional comment. That cleared a lot of things up for me! I will check all your improvement suggestions in detail later (currently afk and only checking this quickly on mobile). For ETA I am currently heavy working on finishing #144 which was long time in backlog due to complexity and of course I will prioritize #364, because fixing bugs always more important than improvements. But I already noticed everything and will give detailed feedback soon! Thanks!

Lurkars commented 1 year ago

So I added now a setting Automatic Theme find under the theme section. This is on by default to not change current behavior. If on this will change

So I combined this together with FH style to not make the settings any more bloated. I think this is enough to keep someone themes and fh style settings when not wished to automatically switched on change.