Lurkars / gloomhavensecretariat

A Gloomhaven / Frosthaven Companion App
https://gloomhaven-secretariat.de
GNU Affero General Public License v3.0
175 stars 66 forks source link

Manage multiple campaigns/parties #371

Closed mentonin closed 11 months ago

mentonin commented 1 year ago
Lurkars commented 1 year ago

Here I have to admit that the current feature of party switching needs a re-labeling to campaign switching, because actually no data is shared between parties (as per rules, like global achievements for example), so actually this is campaign switching (and as labeled with party already available in the campaign management menu). I think that came from my initial misunderstanding of the rules (this feature is really old in comparison to some stuff). So actually, this issue should be more about: implement real party switching by keeping all global stuff etc (which is currently not the case). So happy for you: this feature is already implement, but in the bad side is labeled wrong and the expected feature from label is actually missing 😅

So to sum up the feature: a party is actually a single party campaign with separate stored

So yeah, this needs rework of course and actually add real support for multiple parties in a single campaign and as first change, update all labels and texts about campaign and not party switching (and fix to move character unlocks also to the campaign and not global game state).

Lurkars commented 1 year ago

So as first step, in v0.74.0 I renamed all the current functionality to what it is, a multi-campaign management. Next step is to do the real multi-party management on a campaign.

mentonin commented 1 year ago

That is nice. I think it would be wise to track what needs to be implemented and develop some tests. Off the top of my head, we are looking for the following features:

Honestly, I believe switching campaigns is much more useful than switching parties in a campaign, but that could be just me. Maybe see if someone needs the multi party functionality before working on it?

Lurkars commented 1 year ago

I checked the one point that should already be implemented like this. For the import export you're right, the import should not overwrite. So I will definitely change that (also need to switch label there too, it's import/export campaign currently not party). And you're also right (and that also caused the misunderstanding on my side), when people ask for multi party support they almost always mean multi campaign support and that why I implemented feature as it is. So I will also definitely not focus on real multi party support unless requested.

Lurkars commented 1 year ago

Import will now only overwrite if name and id is matching, otherwise new campaign is created. So multiple campaign management should be complete here and I keep this in backlog if multiple parties becoming relevant sometimes.

Lurkars commented 11 months ago

Okay, I think I'll close this. If multiple parties is requested someday, a new issue will be created.