Lurkars / gloomhavensecretariat

A Gloomhaven / Frosthaven Companion App
https://gloomhaven-secretariat.de
GNU Affero General Public License v3.0
181 stars 70 forks source link

When playing Frosthaven, itemshop doesn't show unlocked Gloomhaven items #415

Closed TheHankerChief closed 1 year ago

TheHankerChief commented 1 year ago

Describe the bug

I started a Frosthaven campaign and manually added items 10,25,72,105,109,116 unlocked for Gloomhaven through the Global Campaign Management link at the top of the Party Sheet. Despite this, accessing the Itemshop from a character sheet doesn't show those gloomhaven items as available.

Game Enviroment

Frosthaven

To Reproduce

  1. Campaign Management
  2. Click Fosthaven
  3. Click Party Sheet
  4. Click Global Campaign Management
  5. Under Unlocked Items, Click Frosthaven and change dropdown to Gloomhaven
  6. Write 10 into the box and click +
  7. Add a character
  8. Click on large character class icon to access character sheet
  9. Click on Itemshop
  10. Gloomhaven item 10 (Warhammer) should be shown

Expected behavior

Unlocked Gloomhaven items should show up in the default itemshop view for a Frosthaven character

Gloomhaven Secretariat Version

v0.77.15

Used Browser

Firefox 118.0.1 64-bit

OS

Windows 11

Additional

No response

Lurkars commented 1 year ago

There is no need to unlock those item manually (and it won't work as you reported). You can simply go to "Settings" and enable "Add Gloomhaven Items" in the "Frosthaven Rules" Section. Then the Gloomhaven Items should be available!

TheHankerChief commented 1 year ago

I thought I had checked settings, but I see it now. It is disabled unless you enable Character Items (management of items during combat rounds). I found this relationship by reading line 754 of Settings.html. These settings probably shouldn't be tied together. Our group will want to run the physical cards at the table, but still track which cards their characters own on Secreteriat.

Thanks!

On Mon, Oct 9, 2023 at 6:32 AM Lurkars @.***> wrote:

There is no need to unlock those item manually (and it won't work as you reported). You can simply go to "Settings" and enable "Add Gloomhaven Items" in the "Frosthaven Rules" Section. Then the Gloomhaven Items should be available!

— Reply to this email directly, view it on GitHub https://github.com/Lurkars/gloomhavensecretariat/issues/415#issuecomment-1752925202, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFTNXDEY7R56RZRSLSN44A3X6PVHJAVCNFSM6AAAAAA5YG2OACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSHEZDKMRQGI . You are receiving this because you were assigned.Message ID: @.***>

Lurkars commented 1 year ago

Yes, you're right! Unsure why I bound this. Will be changed!

Lurkars commented 1 year ago

So I directly addressed this in v0.78.0. First I just removed the check, but now I just bound this to either "Character Sheets" or "Character Items" being enabled, because if BOTH are unchecked, then there really isn't any item management available to address this setting. Hope this is now solved for you. If so, please close issue.

TheHankerChief commented 1 year ago

Thanks! looks like it is working nicely.