Lurkars / gloomhavensecretariat

A Gloomhaven / Frosthaven Companion App
https://gloomhaven-secretariat.de
GNU Affero General Public License v3.0
181 stars 70 forks source link

Adding Items from ItemShop #452

Closed dhyanna closed 8 months ago

dhyanna commented 1 year ago

Describe the bug

As part of Frosthaven road event WR-16, my character gained Item 231 (Skinning Knife). After adding the item to the Unlocked Items, I entered the Itemshop via my character sheet. After searching for the item, I was unable to add this item to my character's equipment, presumably because my character did not have enough gold to purchase it. The Select Item option was grayed out and the only option was to Cancel. Upon temporarily adding enough gold to my character to purchase, I was able to Select the item and then add the item without purchasing it.

Game Enviroment

Frosthaven Edition

To Reproduce

  1. Go to Itemshop and see that an item cannot be selected unless there is enough to purchase
  2. Add enough gold to character sheet to purchase
  3. Return to itemshop and select item
  4. Item can then be added to equipment without purchase

Expected behavior

Items should be able to be selected and added to the character sheet without having enough gold to purchase

Gloomhaven Secretariat Version

0.83.2

Used Browser

Firefox 119.0.1

OS

Windows 10 Pro

Additional

No response

keinkurt commented 1 year ago

Have you try to double click with mouse or long press on mobile device on the item in the itemshop? The you should see a "Add 'Itemname'". Normally this is the method to force add the item to the character.

Lurkars commented 1 year ago

Yes, I understand the issue and will address this beside the workaround. Because when I add the possibility to add an item without costs, then this should be available even when item is not purchasable.

Lurkars commented 11 months ago

Should be fixed in v0.83.4.

stonie73 commented 9 months ago

I just played around with the item shop a lot. I can approve that you have both option in the item shop:

Issue seems to be fixed

dhyanna commented 8 months ago

Thanks!

From: Bernd Steinert @.> Sent: Wednesday, February 28, 2024 2:25 AM To: Lurkars/gloomhavensecretariat @.> Cc: Timothy Bennett @.>; Assign @.> Subject: Re: [Lurkars/gloomhavensecretariat] Adding Items from ItemShop (Issue #452)

I just played around with the item shop a lot. I can approve that you have both option in the item shop:

Issue seems to be fixed

— Reply to this email directly, view it on GitHubhttps://github.com/Lurkars/gloomhavensecretariat/issues/452#issuecomment-1968460664, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABYMVKED5455X4YMCLPO3C3YV3SW3AVCNFSM6AAAAAA74WAT4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRYGQ3DANRWGQ. You are receiving this because you were assigned.Message ID: @.**@.>>