Lurkars / gloomhavensecretariat

A Gloomhaven / Frosthaven Companion App
https://gloomhaven-secretariat.de
GNU Affero General Public License v3.0
182 stars 70 forks source link

Receiving "players has null item" error #530

Closed iamwpj closed 8 months ago

iamwpj commented 8 months ago

Describe the bug

We play on a locally hosted up-to-date version of the application with ghs-server. In the upper left corner by the server connection status a red warning triangle shows indicating an error.

{type: 'error', message: 'players has null item', serverVersion: '0.92.2'}
image

Game Enviroment

release: 92.2

To Reproduce

  1. Open webpage
  2. Often session will wipe and start a new game
  3. Select Menu > Undo (server sync) will bring back the normal session with correct stats. Sometimes importing data results in a slightly off (basically like the data is missing from latest gameplay, but accurate for two scenarios ago, but in the actual backup accurate data is present)
image

Expected behavior

Either an indicator of the missing item/character affected or a log in the server logging.

Gloomhaven Secretariat Version

92.2

Used Browser

Chrome

OS

MacOS 14.4

Additional

No response

Lurkars commented 8 months ago

Could you please send me a data dump by email (just use the feedback button in the menu!). It would help me a lot to investigate the problem.

iamwpj commented 8 months ago

Sent!

Lurkars commented 8 months ago

I think I could identify and fix the issue in client while I have still no idea how you created that state, but anyways, please checkout with latest client v0.92.4 if the fix is working and if so close issue. Thanks.

iamwpj commented 8 months ago

I deleted the client files and pulled 0.92.4 and got the same issue.

Lurkars commented 8 months ago

I am not able to reproduce with your send backup. Are you using multiple parties?

iamwpj commented 8 months ago

I looked at this this morning and found that I hadn't moved the correct client files. Your fix did the trick! Many thanks!